- Global buffer_config_preference_xml (GString *, iterator_t *, config_t, int)
- g_convert back to ISO-8559-1 for scanner?
- Global buffer_config_preference_xml (GString *, iterator_t *, config_t, int)
- g_convert back to ISO-8559-1 for scanner?
- Global buffer_results_xml (GString *, iterator_t *, task_t, int, int, int, int, int, int, int, const char *, iterator_t *, int, int)
Exported for manage_sql.c.
Exported for manage_sql.c.
Defined in gmp.c!
- Global buffer_results_xml (GString *, iterator_t *, task_t, int, int, int, int, int, int, int, const char *, iterator_t *, int, int)
Defined in gmp.c!
Exported for manage_sql.c.
Exported for manage_sql.c.
- Global cleanup ()
- These should happen via gmp, maybe with "cleanup_gmp ();".
- Global config_nvts_growing (config_t config)
- Move these config functions to the config section.
- Global create_nsis_script (const gchar *script_name, const gchar *package_name, const gchar *user_name, const gchar *password)
provide /comment:"GVM User" /fullname:"GVM Testuser"
Display note about NTLM and SMB signing and encryption, 'Easy Filesharing' in WIN XP
Uninstaller should remove itself
- Global create_tables_version_4 ()
May be better ensure a ROLLBACK when functions like "sql" fail.
INTEGER
- Global fork_connection_internal (gvm_connection_t *client_connection, const gchar *uuid, int scheduler)
- Give the parent time to prepare.
- Global fork_update_nvt_cache ()
- This should happen via gmp, maybe with "cleanup_gmp ();".
- Global from_buffer_size
- As with the GMP version, this should most likely be passed to and from the client in a data structure like an otp_parser_t.
- Global from_client [FROM_BUFFER_SIZE]
- Most likely the client should get these from init_gmp_process inside an gmp_parser_t and should pass the gmp_parser_t to process_gmp_client_input. process_gmp_client_input can pass then pass them on to the other Manager "libraries".
- Global from_client [FROM_BUFFER_SIZE]
- Most likely the client should get these from init_gmp_process inside an gmp_parser_t and should pass the gmp_parser_t to process_gmp_client_input. process_gmp_client_input can pass then pass them on to the other Manager "libraries".
- Global from_scanner
- As with the GMP version, these should most likely be passed to and from the client in a data structure like an otp_parser_t.
- Global G_LOG_DOMAIN
Consider moving to libs (so please leave "server" in the names).
For access to scanner_t scanner.
For scanner_init_state.
Ensure that the globals used to store information across the XML parser callbacks (for example, current_scanner_preferences) are freed in the failure cases.
- Global gmp_xml_handle_end_element (GMarkupParseContext *context, const gchar *element_name, gpointer user_data, GError **error)
Or some other error occurred.
Consider reverting parsing for retry.
process_gmp_client_input must return -2.
Legitimate to pass an empty hosts element?
Any fail cases of the CLIENT_CREATE_TASK_* states must do so too.
Respond with error or something.
Respond with error or something.
Consider reverting parsing for retry.
process_gmp_client_input must return -2.
- Global gmp_xml_handle_start_element (GMarkupParseContext *context, const gchar *element_name, const gchar **attribute_names, const gchar **attribute_values, gpointer user_data, GError **error)
Free globals when tags open, in case of duplicate tags.
If a real GMP command, return STATUS_ERROR_MUST_AUTH.
- Global handle_get_configs (gmp_parser_t *gmp_parser, GError **error)
- This should really be an nvt_selector_t.
- Global handle_get_reports (gmp_parser_t *gmp_parser, GError **error)
Some checks only required when type is "scan".
Respond in all error cases.
- Global init_classic_asset_iterator (iterator_t *iterator, int first_result, int max_results, const char *levels, const char *search_phrase, int apply_overrides)
- Include tasks.hidden and task pref in_assets?
- Global insert_nvt_selectors (const char *quoted_name, const array_t *selectors)
- Check that selector->type is actually an integer.
- Global manage_task_update_file (const gchar *task_id, const char *name, const void *content)
- Probably better to save ASCII instead of base64.
- Class message_t
- Should be in otp.c/h.
- Global openvas_scanner_read ()
- Rehandshake.
- Global parse_scanner_bad_login (char **messages)
- Are there 19 characters available?
- Global parse_scanner_server (char **messages)
Is there ever whitespace before the newline?
Are there 20 characters available?
Are there 12 characters available?
- Class port_t
- Should be in otp.c/h.
- Global print_report_port_xml (report_t report, FILE *out, const get_data_t *get, int first_result, int max_results, int sort_order, const char *sort_field, GHashTable *host_ports)
- Sort by ROWID if was requested.
- Global print_report_xml_start (report_t report, report_t delta, task_t task, gchar *xml_start, const get_data_t *get, const char *type, int notes_details, int overrides_details, int result_tags, const char *host, int pos, const char *host_search_phrase, const char *host_levels, int host_first_result, int host_max_results, int ignore_pagination, gchar **filter_term_return, gchar **zone_return, gchar **host_summary)
Leaks on error in PRINT and PRINT_XML. The process normally exits then anyway.
The f_debugs, etc. vars are setup to give the page count.
- Global process_gmp (gmp_parser_t *parser, const gchar *command, gchar **response)
- The -2 return has been replaced by send_to_client trying to write the to_client buffer to the client when it is full. This is necessary, as the to_client buffer may fill up halfway through the processing of a GMP element.
- Global process_gmp_client_input ()
- The -2 return has been replaced by send_to_client trying to write the to_client buffer to the client when it is full. This is necessary, as the to_client buffer may fill up halfway through the processing of a GMP element.
- Global process_otp_scanner_input ()
Replace "\n" with newline in description.
Field could be "general".
Replace "\n" with newline in description.
Field could be "general".
Replace "\n" with newline in description.
Field could be "general".
Exit more formally with Scanner?
Consider reading all fields up to <|> SERVER?
- Global read_from_client_tls (gnutls_session_t *client_session)
- Rehandshake.
- Global report_counts (const char *report_id, int *debugs, int *holes, int *infos, int *logs, int *warnings, int *false_positives, double *severity, int override, int autofp, int min_qod)
- Lacks permission check. Caller contexts all have permission checks before calling this so it's safe. Rework callers to use report_counts_id instead.
- Global report_timestamp (const char *report_id, gchar **timestamp)
- Lacks permission check. Caller contexts all have permission checks before calling this so it's safe. Rework callers so they pass report_t instead of UUID string.
- Global reset_scanner_states ()
- Exported for scanner.c.
- Global run_otp_task (task_t task, scanner_t scanner, int from, char **report_id)
On fail exits only, may need to honour request states that one of the other processes has set on the task (stop_task, request_delete_task).
Also reset status on report, as current_scanner_task is 0 here.
- Global run_slave_or_gmp_task (task_t task, int from, char **report_id, gvm_connection_t *connection, const gchar *slave_id, const gchar *slave_name)
On fail exits only, may need to honour request states that one of the other processes has set on the task (stop_task, request_delete_task).
Also reset status on report, as current_scanner_task is 0 here.
- Global scanner_init_offset
- Exported for gmpd.c.
- Global scanner_init_state
- Exported for gmpd.c.
- Global scanner_init_state_t
- Exported for following functions.
- Global send_element_error_to_client (const char *command, const char *element, int(*write_to_client)(const char *, void *), void *write_to_client_data)
- Set gerror so parsing terminates.
- Global serve_gmp (gvm_connection_t *, const gchar *, gchar **)
Confirm and clarify complications, especially last one.
nfds must only include a socket if it's in >= one set.
Shutdown on failure (for example, if a read fails).
Then should get EOF (-3).
This may be because the scanner closed the connection at the end of a command?
- Global serve_gmp (gvm_connection_t *, const gchar *, gchar **)
Confirm and clarify complications, especially last one.
nfds must only include a socket if it's in >= one set.
Shutdown on failure (for example, if a read fails).
Then should get EOF (-3).
This may be because the scanner closed the connection at the end of a command?
- Global set_scanner_init_state (scanner_init_state_t state)
- Exported for gmpd.c and scanner.c.
- Global target_port_list (target_t target)
- Move return to arg; return -1.
- Global task_trend (task_t task, int override, int min_qod)
Either fail better or abort at SQL level.
Either fail better or abort at SQL level.
- Global to_client []
- As described in gmp.c, probably should be replaced by gmp_parser_t.
- Global to_client []
- As described in gmp.c, probably should be replaced by gmp_parser_t.
- Global write_string_to_server (char *const string)
- Rehandshake.
- Global write_to_client_tls (gnutls_session_t *client_session)
Move to openvas-libraries?
Rehandshake.
- Global write_to_server_buffer ()
- Rehandshake.